binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

added all the ps and other ppc extensions, need to decide on getopt for windows stuff and resolve default architecture

Open v1X3Q0 opened this issue 1 year ago • 3 comments

Adding the other powerpc extensions, unfortunately unix to windows differences require some external libraries.

  • Need to decide if its ok to either submodule https://github.com/v1X3Q0/getopt-for-windows.git or if we should not include windows support.
  • Default to ppc_ps for the architecture right now, need to fix it so it defaults to ppc and correctly allows selection of each architecture arbitrarily.
  • To have each architecture properly selected, may require adding platforms for each.

v1X3Q0 avatar Mar 12 '24 17:03 v1X3Q0

Just to put it here, I've asked the author (on slack) to remove the getopt dependency, so test_asm/test_disasm won't support Windows for now.

galenbwill avatar Mar 12 '24 17:03 galenbwill

I'm mariomain, windows stuff has been removed. will still look into the other 2 bullets in a bit.

v1X3Q0 avatar Mar 12 '24 18:03 v1X3Q0

i submitted a review because otherwise it wouldn't actually show my comments, but consider my review as still being "in progress"

galenbwill avatar Apr 10 '24 00:04 galenbwill