first-setup icon indicating copy to clipboard operation
first-setup copied to clipboard

seemingly pointless desktop entry

Open taukakao opened this issue 1 year ago • 5 comments

The nextBoot file creates a .desktop entry in ~/.local/share/applications with:

echo "[Desktop Entry]" > /home/$REAL_USER/.local/share/applications/org.vanillaos.FirstSetup.desktop
echo "Name=FirstSetup" >> /home/$REAL_USER/.local/share/applications/org.vanillaos.FirstSetup.desktop
echo "Comment=FirstSetup" >> /home/$REAL_USER/.local/share/applications/org.vanillaos.FirstSetup.desktop
echo "Exec=vanilla-first-setup" >> /home/$REAL_USER/.local/share/applications/org.vanillaos.FirstSetup.desktop
echo "Terminal=false" >> /home/$REAL_USER/.local/share/applications/org.vanillaos.FirstSetup.desktop
echo "Type=Application" >> /home/$REAL_USER/.local/share/applications/org.vanillaos.FirstSetup.desktop
echo "NoDisplay=true" >> /home/$REAL_USER/.local/share/applications/org.vanillaos.FirstSetup.desktop

Since it has the NoDisplay tag set to true, it's not obvious why its being created.

Also, even if it's there for a reason, since it's hardcoded it might as well be in /etc/skel or /usr/share/applications

taukakao avatar Apr 13 '24 00:04 taukakao

That entry is being created to hinibit the original First Setup desktop entry and hide it from the apps menu

mirkobrombin avatar Apr 13 '24 12:04 mirkobrombin

@mirkobrombin Since the user will never see the original desktop entry in the restricted shell mode, couldn't we just add NoDisplay=true to the original one.

taukakao avatar Apr 13 '24 12:04 taukakao

@mirkobrombin Since the user will never see the original desktop entry in the restricted shell mode, couldn't we just add NoDisplay=true to the original one.

I'm not worried about that but the fact that in reality the first setup app will still be available once the system has been installed and we no longer have to show it in the applications menu. But at the same time we cannot remove it because new users must be able to use it in the restricted session.

Maybe there is a way to only show it in the restricted session?

mirkobrombin avatar Apr 13 '24 14:04 mirkobrombin

@mirkobrombin

Maybe there is a way to only show it in the restricted session?

What do you mean by that? The restricted shell autostarts first-setup and doesn't even have an overview so the NoDisplay=true wouldn't affect this.

taukakao avatar Apr 13 '24 14:04 taukakao

@mirkobrombin

Maybe there is a way to only show it in the restricted session?

What do you mean by that? The restricted shell autostarts first-setup and doesn't even have an overview so the NoDisplay=true wouldn't affect this.

This is actually a great observation and I didn't think about it. 10 points to Gryffindor.

mirkobrombin avatar Apr 13 '24 14:04 mirkobrombin