the_lab_renderer icon indicating copy to clipboard operation
the_lab_renderer copied to clipboard
verified publisher icon ValveSoftware

Fix #13: move UpdateAdaptiveQuality() to LateUpdate.

Open TrebuhD opened this issue 9 years ago • 5 comments

Fix the adaptive quality screen flicker bug by moving UpdateAdaptiveQuality() from OnPreCull() to LateUpdate() in ValveCamera.cs, as suggested by @Selkcip.

TrebuhD avatar Oct 19 '16 19:10 TrebuhD

I still get a "jump" anytime it changes quality. Is that to be expected? Seems like not.

SpencerMalone avatar Oct 28 '16 16:10 SpencerMalone

I guess it's not every time it changes quality, but there is certainly an increase in the lurches that I get.

SpencerMalone avatar Oct 28 '16 16:10 SpencerMalone

Is it hitching or are you seeing a skewed frame? This won't fix occasional hitching, but does fix a serious bug where a single, very obvious, frame would be rendered with the wrong viewport dimensions making things unplayable.

Selkcip avatar Oct 29 '16 08:10 Selkcip

It was hitching, as it turns out. Not sure if it was reimporting the assets or bumping up my unity version, but one of the two solved it. I think I was getting hitching+the frame thing before, and this definitely fixed the frame badness, but left the hitching (because it was my fault 😿 ). Anyways, this LGTM!

SpencerMalone avatar Oct 31 '16 13:10 SpencerMalone

it does fixed flickering by moving UpdateAdaptiveQuality(); to lateupdate.

mikejichaow avatar Mar 16 '17 18:03 mikejichaow