steamvr_unreal_plugin icon indicating copy to clipboard operation
steamvr_unreal_plugin copied to clipboard

Key pressed events keep coming even when the controller is off in 4.24.2

Open muchcharles opened this issue 6 years ago • 8 comments

If the controller is turned off while a key is pressed, unreal will keep firing key events for it even if the controller was turned off before Unreal launched. I got this first with grip events on index but also tested with the A button (it must have first happened due to gripping while turning the controller off, which can be hard not to do).

I saw this on both SteamVR 1.10.7 and 1.10.8 (haven't tried stable yet).

4.24.2 seems to have added some logic around triggering key repeat events that wasn't there in 4.24.1 and that may be part of why it started showing up. But it may also be that steamvr should be clearing out the controller pressed state when a controller is turned off, because it does seem to leave the stuff set and bActive true:

image

muchcharles avatar Jan 30 '20 22:01 muchcharles

Hi @muchcharles - Unable to replicate this in 1.9.16 & 1.10.8 - which controller are you using?

1runeberg avatar Jan 31 '20 02:01 1runeberg

Knuckles DV. I just got a clean engine debug build from tag 4.24-release without any of my branch and I'm still seeing it. I held down the A button as I turned off the controller with steamvr running, and launched UE4 afterwards:

image

(screenshot got cropped a bit, the MessageHandler->OnControllerButtonPressed line with two horizontal grey lines is where things are in the debugger)

This was in the stock engine VR template.

muchcharles avatar Jan 31 '20 20:01 muchcharles

Hi @muchcharles - Is this test project just the standard VR Template?

Can you uncomment those two UE_LOGS and send me the result you are getting? Also your SteamVR System Report with logs that were being generated at the same time as when you are observing the repeats) all to [email protected] please.

Thanks, Rune

1runeberg avatar Feb 01 '20 01:02 1runeberg

Sure, I'll mail you a system report taken while running it. This is what shows when those logs are uncommented

[2020.02.01-03.49.11:460][ 1]LogTemp: Warning: Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34448.824219 [2020.02.01-03.49.11:461][ 1]LogTemp: Warning: Handle /actions/main/in/GrabLeft KeyX MixedReality_Left_Trigger_Click Value 1 Changed 0 UpdateTime -34438.761719 [2020.02.01-03.49.11:703][ 4]LogTemp: Warning: [REPEAT] Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34449.066406 [2020.02.01-03.49.11:704][ 4]LogTemp: Warning: [REPEAT] Handle /actions/main/in/GrabLeft KeyX MixedReality_Left_Trigger_Click Value 1 Changed 0 UpdateTime -34439.003906 [2020.02.01-03.49.11:807][ 11]LogTemp: Warning: [REPEAT] Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34449.171875 [2020.02.01-03.49.11:808][ 11]LogTemp: Warning: [REPEAT] Handle /actions/main/in/GrabLeft KeyX MixedReality_Left_Trigger_Click Value 1 Changed 0 UpdateTime -34439.109375 [2020.02.01-03.49.11:939][ 18]LogTemp: Warning: [REPEAT] Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34449.300781

muchcharles avatar Feb 01 '20 03:02 muchcharles

One thing you might make sure of in reproducing it is that the dashboard doesn't open, sometimes when turning off the controller that seems to happen and could maybe consume the inputs.

muchcharles avatar Feb 01 '20 03:02 muchcharles

thanks. please make sure you send me the full UE LOG as well :)

Cheers, Rune

1runeberg avatar Feb 01 '20 04:02 1runeberg

Looks like a couple people have reported this recently for steamvr in general:

https://github.com/ValveSoftware/openvr/issues/1296

muchcharles avatar Feb 01 '20 17:02 muchcharles

was tricky to replicate as turning off the controller for Index at least is difficult while a button is pressed. but it appears if you press and unpress while turning it off then subsequent shutdowns with a press works.

still investigating this however, but it does point to a potential steamvr issue.

1runeberg avatar Feb 03 '20 23:02 1runeberg