openxr_engine_plugins icon indicating copy to clipboard operation
openxr_engine_plugins copied to clipboard

xrEnumerateViveTrackerPathsHTCX results are not used

Open RemiArnaud opened this issue 4 years ago • 1 comments

https://github.com/ValveSoftware/openxr_engine_plugins/blob/272c1470b95677f6dd131e4d707ffa985fab1ffb/unreal_engine/ue4/OpenXRViveTracker/Source/OpenXRViveTracker/Private/OpenXRViveTracker.cpp#L200

I was wondering why calling xrEnumerateViveTrackerPathsHTCX but not using the result.

also, wondering if it is intentional the event XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED (18) is ignored in OnEvent()

RemiArnaud avatar Dec 21 '21 03:12 RemiArnaud

It was meant for troubleshooting connection issues and as a code sample for devs. There wasn't any need to use the info currently in the way the plugin was designed.

Re: Data session - yes, this was meant only for debugging. But good point, should probably simply put a proper debug level so there's no need to comment out. will make the necc changes. thanks.

1runeberg avatar Jan 03 '22 22:01 1runeberg