gamescope icon indicating copy to clipboard operation
gamescope copied to clipboard

Remove global -ffast-math flag, instead apply fast math to just color_helpers.cpp

Open sharkautarch opened this issue 1 year ago • 8 comments

Should fix https://github.com/ValveSoftware/gamescope/issues/1493

sharkautarch avatar Aug 29 '24 20:08 sharkautarch

I'd rather just have the pragma thing, rather than the denorms thing... We can come back to it if we want it.

misyltoad avatar Aug 29 '24 20:08 misyltoad

@Joshua-Ashton instead of turning on ftz/daz globally, I ended up using some intrinsics for x86 and aarch64 to just turn on ftz/daz inside ~~calcColorTransform~~ create_color_mgmt_luts, w/ the msrs being restored after returning from the function Let me know if this is ok, or just too complicated

sharkautarch avatar Aug 29 '24 21:08 sharkautarch

Can confirm this fixes #1493.

Exotic0015 avatar Aug 29 '24 22:08 Exotic0015

Edited to remove the msr things as per misyl’s feedback

sharkautarch avatar Oct 08 '24 12:10 sharkautarch

This should also fix #1622.

bandithedoge avatar Nov 29 '24 17:11 bandithedoge

Slight edit to PR: reduced the scope of FAST_MATH_ON so that it no longer is applied to glm headers (except for the matrix headers, bc it's unlikely to be used outside of color_helpers.cpp), in case they are ever used outside of the color helpers stuff in the future

sharkautarch avatar Dec 03 '24 17:12 sharkautarch

can also confirm that using this PR fixes the bluriness with gamescope, even at native resolutions. Is this going to be merged soon?

fxzzi avatar Jan 10 '25 10:01 fxzzi

Is this going to be merged soon?

I’ll check in with misyl on that soon Currently the higher priority PR is : https://github.com/ValveSoftware/gamescope/pull/1697

sharkautarch avatar Jan 10 '25 11:01 sharkautarch

Hi, any news on this? Seems to have been left for a while and without this PR pretty much makes gamescope unusable for me

fxzzi avatar Jul 30 '25 14:07 fxzzi

Hi, any news on this? Seems to have been left for a while and without this PR pretty much makes gamescope unusable for me

I'll checkin with misyl/august

sharkautarch avatar Jul 30 '25 14:07 sharkautarch

@fxzzi So it turns out that unfortunately, the gamescope dev is on holiday until the 12th So I don’t think this PR will be able to get merged until then (unless something’s changed recently, there’s only one gamescope developer)

sharkautarch avatar Aug 02 '25 14:08 sharkautarch