Source-1-Games icon indicating copy to clipboard operation
Source-1-Games copied to clipboard

TF2 HHH Burning effect missing

Open HHHJrr opened this issue 3 years ago • 3 comments

Ever since 2015 October in the Invasion or Scream Fortress update(i only noticed it much later but seems around that time) The Horseless Headless Horsemann Halloween boss lost the purple flame effect on it's body. HorsemannFlame I didn't see the change mentioned anywhere or anyone noticing the change, but the image above has a clear difference.

HHHJrr avatar Oct 08 '22 21:10 HHHJrr

Perhaps this was done to reduce visual clutter and strain on resources? Although the old HHH with the flames present looks so much cooler indeed.

Platina6978 avatar Oct 09 '22 07:10 Platina6978

it was an undocumented change and to be frank, i don't get why they did it, monoculus still has purple flaming bits on him. it just makes the horsemann look really plain. now he just looks like a scaled up demoknight with a footstep spell equipped.

Whurrhurr avatar Oct 09 '22 08:10 Whurrhurr

It's probably a bug or an oversite, pls bring it back!

condor00fr avatar Oct 09 '22 11:10 condor00fr

Documented this on both English and French versions of the Wiki. Listed it as a bug

condor00fr avatar Dec 25 '22 09:12 condor00fr

[TF2] Horseless Headless Horseman body fire particle has been broken due a coding mistake.

Issue transferred from https://github.com/ValveSoftware/Source-1-Games/issues/5035. @FriskTheFallenHuman posted on 2023-07-13T17:52:23:

This issue is kind of related to #4383 but with a solution: after the 2015 update the HHH lost its body flame, it was speculated that it was because of valve removing it, but in reality, is it was by mistake here's a brief explanation:

For some unknow reason after the invasion updated The Horseless Headless Horseman lost its body flame particle, while it was speculated that it was removed because of visibility reasons, in reality this was by mistake, since the particles of it do exist albeit it only exists for a fraction of a frame when the entity spawns, the fix was from moving it from the clientside's Spawn() function:

void C_HeadlessHatman::Spawn( void )
{
	// Some other code

	if ( !m_ghostEffect )
	{
		m_ghostEffect = ParticleProp()->Create( "ghost_pumpkin", PATTACH_ABSORIGIN_FOLLOW );
	}

	// Some other code
}

to ClientThink() since that's how to properly spawn a particle client-side in the engine.

void C_HeadlessHatman::ClientThink( void )
{
	// Some other code

	if ( !m_ghostEffect )
	{
		m_ghostEffect = ParticleProp()->Create( "ghost_pumpkin", PATTACH_ABSORIGIN_FOLLOW );
	}

	// Some other code
}

This means that at some point the particle mas mistakenly moved from ClientThink() to Spawn() meaning the particle only would be live for a fraction of a frame.

kisak-valve avatar Jul 13 '23 18:07 kisak-valve

The latest Scream Fortress update seems to have fixed HHH's fire particles not showing up ">Fixed ghost_pumpkin effect not playing correctly for the Horseless Headless Horsemann" Retest needed

HueyCan avatar Oct 09 '23 21:10 HueyCan

Yea it seems to be fixed, for me atleast.

HHHJrr avatar Oct 11 '23 13:10 HHHJrr

can confirm this has been fixed, Burnt Horsemann on plr_hacksaw_event looks a little weird now though, some extra ghost_pumpkin effects are on one of his hands. image

Whurrhurr avatar Oct 11 '23 16:10 Whurrhurr