GameNetworkingSockets icon indicating copy to clipboard operation
GameNetworkingSockets copied to clipboard

NULL reference crash.

Open fred4d opened this issue 3 years ago • 1 comments

It is possible for nullptr to be returned from:

IBoundUDPSocket *CSharedSocket::AddRemoteHost( const netadr_t &adrRemote, CRecvPacketCallback callback )

This nullptr will get assigned to pRequest->m_pSocket at least in:

CSteamNetworkingSocketsSTUNRequest *CSteamNetworkingSocketsSTUNRequest::SendBindRequest CSteamNetworkingSocketsSTUNRequest *CSteamNetworkingSocketsSTUNRequest::CreatePeerConnectivityCheckRequest

Subsequent dereferences of m_pSocket will naturally crash.

fred4d avatar Jul 16 '22 23:07 fred4d

Spotted same bug when tried master branch month ago. Just tried to connect 2 users with networking messages. Reverted back to 8 month old version.

djdron avatar Aug 02 '22 16:08 djdron

Fixed by d5f855967440eeb5b4d5798bebe179ef868ac6af

zpostfacto avatar Oct 12 '22 18:10 zpostfacto