vunit icon indicating copy to clipboard operation
vunit copied to clipboard

Fix axi_lite_master wait behaviour if idle

Open eschmidscs opened this issue 4 years ago • 6 comments

The axi_lite_master did wait forever on wait_for_idle if it was already idle. I tried to fix it here.

eschmidscs avatar Jan 18 '22 17:01 eschmidscs

If I understand the failing task, it is not related to my change. Can anyone check this please?

eschmidscs avatar Jan 18 '22 19:01 eschmidscs

If I understand the failing task, it is not related to my change. Can anyone check this please?

It seems that Sphinx was updated to v.4.4.0 and it is now showing that error. Please, replace the reference reported in the error with:

:vunit_example:`vhdl/array`

umarcor avatar Jan 18 '22 19:01 umarcor

Looks good from my point of view. The only alternative solution I can come to think of is to push an extra dummy "token" into the queue after the request message and then pop that at the end of the bus process. The component is idle if the queue is empty. I can't say that one is better or more beautiful than the other so you can decide.

LarsAsplund avatar Jan 18 '22 21:01 LarsAsplund

@umarcor Tried to do that, the new link does not seem to work. A similar error shows up now, but I can't even find that static link in examples.rst?

eschmidscs avatar Jan 20 '22 14:01 eschmidscs

@eschmidscs I fixed doc issues in master. If you rebase, it should be green.

umarcor avatar Feb 05 '22 00:02 umarcor

I'm hitting this error, can this PR be merged?

creiter64 avatar Jun 28 '22 16:06 creiter64