Vim icon indicating copy to clipboard operation
Vim copied to clipboard
verified publisher icon VSCodeVim

Implement normal command

Open s-kai273 opened this issue 1 year ago • 7 comments

What this PR does / why we need it:

  • [x] implement normal command(both for single line and multi lines)
  • [x] test codes of normal command

Which issue(s) this PR fixes

Special notes for your reviewer

  • hope to check implementation design is proper it is designed referring to macro implementation.

s-kai273 avatar Feb 21 '24 15:02 s-kai273

I implemented test codes. If it is necessary to add more test cases, please tell me it.

s-kai273 avatar Mar 15 '24 12:03 s-kai273

@J-Fields Thank you for your reviewing. I finished to modify and comment the code. Please check it.

s-kai273 avatar Mar 30 '24 10:03 s-kai273

@J-Fields @feeiyu

Hi, I have completed the revisions to my code as per your comments. If there are any additional adjustments needed, please let me know.

Thank you for your feedback.

s-kai273 avatar May 13 '24 17:05 s-kai273

After merging https://github.com/VSCodeVim/Vim/pull/8979, some conflicts occurred. I have fixed them in commit dbd0bd2.

s-kai273 avatar May 20 '24 14:05 s-kai273

@J-Fields Thank you for your review. I have addressed all the points you mentioned.

s-kai273 avatar May 27 '24 03:05 s-kai273

@s-kai273 Just one more unresolved comment: https://github.com/VSCodeVim/Vim/pull/8896#discussion_r1614900548

J-Fields avatar May 27 '24 19:05 J-Fields

@J-Fields Thanks, I fixed https://github.com/VSCodeVim/Vim/pull/8896#discussion_r1614900548. Please check it!

s-kai273 avatar May 28 '24 13:05 s-kai273