Vim icon indicating copy to clipboard operation
Vim copied to clipboard

Problem view doesn't close on Escape

Open mario-holubar opened this issue 2 years ago • 1 comments

Describe the bug When the inline diagnostics / problem view is visible, the Esc key should be passed through to VSCode and close the popup (#3416). It doesn't do this by default, but when I create the exact same keybind manually, it does.

To Reproduce Steps to reproduce the behavior:

  1. Have an error / warning in your code.
  2. Press F8 to jump to it. A preview opens describing the error.
  3. Press Esc. The problem view does not disappear.
  4. Add this to keybindings.json:
{
    "key": "escape",
    "command": "closeMarkersNavigation",
    "when": "editorFocus && markersNavigationVisible"
},
  1. Repeat steps 2 and 3. The problem view now disappears.

Expected behavior The window should close on Esc without having the redefine the keybind.

Screenshots Custom keybind that fixes the issue is identical to default one: keybinds

Log output Before custom keybind:

2024-02-02 01:47:28.721 [debug] Selection change: [47, 8], [47, 8], SelectionsLength: 1
2024-02-02 01:47:28.721 [debug] Selections: Changing Cursors from selection handler... [47, 8], [47, 8]
2024-02-02 01:47:33.418 [debug] Handling key: <Esc>

After custom keybind:

2024-02-02 01:47:38.444 [debug] Selection change: [47, 8], [47, 8], SelectionsLength: 1
2024-02-02 01:47:38.444 [debug] Selections: Changing Cursors from selection handler... [47, 8], [47, 8]

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.27.2
  • VSCode version: 1.86
  • OS: Ubuntu 22.04.3 LTS

Additional context Related open issues: #2258, #3716.

mario-holubar avatar Feb 02 '24 01:02 mario-holubar

it looks like it's already been fixed.

HenryTSZ avatar Jun 21 '24 06:06 HenryTSZ