VKUI icon indicating copy to clipboard operation
VKUI copied to clipboard

fix(ChipsSelect/ChipsInput): Pass option disabled and readonly to renderChip

Open mendrew opened this issue 1 year ago • 5 comments

  • [x] Unit-тесты

Описание

Бывает, что хочется некоторые chips уже сразу сделать выбранными по умолчанию, не давая их убрать. Например, с помощью disabled и readOnly свойств.

Оказалось, что для ChipsInput мы позволяем задать disabled или readOnly только для всех chips разом.

file NflMcn

Изменения

Используем значение disabled/readOnly из option при рендере chips.

mendrew avatar Jun 28 '24 15:06 mendrew

size-limit report 📦

Path Size
JS 368.66 KB (+0.01% 🔺)
JS (gzip) 112.87 KB (+0.01% 🔺)
JS (brotli) 92.94 KB (+0.09% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 289.84 KB (0%)
CSS (gzip) 37.66 KB (0%)
CSS (brotli) 30.44 KB (0%)

github-actions[bot] avatar Jun 28 '24 15:06 github-actions[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jun 28 '24 15:06 codesandbox-ci[bot]

e2e tests

Playwright Report

github-actions[bot] avatar Jun 28 '24 15:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.78%. Comparing base (7d4f104) to head (a579e43). Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7098   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files         357      357           
  Lines       10676    10678    +2     
  Branches     3551     3553    +2     
=======================================
+ Hits         8945     8947    +2     
  Misses       1731     1731           
Flag Coverage Δ
unittests 83.78% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 28 '24 15:06 codecov[bot]

👀 Docs deployed

Commit a579e4318b801bd01b8b6354a2007d3bfeeb8e3c

github-actions[bot] avatar Jun 28 '24 15:06 github-actions[bot]

v6.2.1 🎉

vkcom-publisher avatar Jul 08 '24 16:07 vkcom-publisher