Befaco icon indicating copy to clipboard operation
Befaco copied to clipboard

pulse wave has a huge amount of DC on it

Open squinkylabs opened this issue 3 years ago • 3 comments

It's debatable, but I think most ppl don't want a "audio frequency" pulse wave to be DC coupled.

image

squinkylabs avatar Jul 22 '22 18:07 squinkylabs

THanks for the report. I think it's probably not desirable, but it is at least representative of the hardware. If this is fixed, I suggest it's done as a context menu option (default disabled). You do get qualitatively different results (e.g. audio rate PM, FM something else).

You can remove it arithmetically or by filter, how would you approach this?

hemmer avatar Jul 24 '22 16:07 hemmer

In my VCOs I compensate for the DC, just like I do with the DC added by the minBLEP saw. I reported this "bug" to Bogaudio and they fixed it last year. (so, yeah, algorithmically. I think I basically subtract out the pulse width?)

It is true that there are LFO uses where you do want the DC, but in general I hear so many VCV recordings with unintentional pops...

For more on DC: https://github.com/squinkylabs/Demo/blob/main/docs/dc.md

squinkylabs avatar Jul 29 '22 15:07 squinkylabs

HOping to merge this fix back soon!

https://github.com/hemmer/Befaco/commit/ecf835fa629e173bcb2b8dca273df8641af7e0c9#diff-472081787c8ad26eb4b8712029553b2ba85aee31499653dddd25b359401c2c22

hemmer avatar Oct 07 '22 12:10 hemmer