Focusly icon indicating copy to clipboard operation
Focusly copied to clipboard

Add spinner

Open Utkarshn10 opened this issue 3 years ago • 11 comments

Add spinner to cards.

A spinner should be added to the cards so the user knows that the sound is being loaded.

Utkarshn10 avatar Aug 09 '22 01:08 Utkarshn10

i'm interested i'd like to fix this

hoyeen01 avatar Aug 10 '22 16:08 hoyeen01

Thanks @hoyeen01 for considering contributing to Focusly. Issue assigned.

Utkarshn10 avatar Aug 11 '22 03:08 Utkarshn10

thank you for giving me this opportunity

hoyeen01 avatar Aug 11 '22 11:08 hoyeen01

@Utkarshn10 hello i need to clarify something is the spinner supposed to load before it plays or while the sound is playing

hoyeen01 avatar Aug 12 '22 12:08 hoyeen01

@Utkarshn10 hello i need to clarify something is the spinner supposed to load before it plays or while the sound is playing Hey @hoyeen01 the spinner should load before audio is played.

Utkarshn10 avatar Aug 12 '22 14:08 Utkarshn10

okay thank you

hoyeen01 avatar Aug 12 '22 14:08 hoyeen01

@Utkarshn10 i tried fixing this but the onload function is not working as expected i was expecting it to get called when the sound loaded but its not working properly as you can see and i checked, someone has raised an issue about it https://github.com/leoasis/react-sound/issues/93

https://user-images.githubusercontent.com/98392620/184394229-abe50731-8085-493b-b16d-e544cf11ac62.mp4

hoyeen01 avatar Aug 12 '22 15:08 hoyeen01

We can fix it when the react-sound' s issue is resolved. Thanks @hoyeen01 for helping with this issue :)

Utkarshn10 avatar Aug 13 '22 03:08 Utkarshn10

i'm having issues pushing the changes 2022-08-17

hoyeen01 avatar Aug 17 '22 14:08 hoyeen01

Hey @hoyeen01 there might be some issue with your PAT(personal access token). Could you please check it. This link might help.

Utkarshn10 avatar Aug 17 '22 16:08 Utkarshn10

Hey @hoyeen01 we have shifted to ReactAudioPlayer. You can now push your changes. Thanks :)

Utkarshn10 avatar Feb 11 '23 07:02 Utkarshn10