routes icon indicating copy to clipboard operation
routes copied to clipboard

Add feature to include current route slug in body

Open thaikolja opened this issue 3 years ago • 2 comments

This pull requests extends Upstament's Router by allowing users whether they'd like to display the sanitized slug of the current route in the

tag or not. This may play a big role in CSS and other areas.

Additionally, one parameter has been added to the map() function, after args, called add_to_body which is boolean and set to true on default. However, this can be changed individually for any loaded route fike.

Signed-off-by: Kolja Nolte <[email protected]>

thaikolja avatar Oct 31 '21 23:10 thaikolja

Thanks @thaikolja! this is an interesting idea. Please see my review for some quick feedback.

Could you re-submit without the other formatting/linting changes? That way we can focus fully on the functionality/code change (though I'm happy to consider a PR for formatting changes — but want those closely aligned with WP standards)

jarednova avatar Nov 02 '21 18:11 jarednova

Hi @jarednova, thanks for taking the time, and have a look. I think I fixed the formatting issue. I wrote a bit more in my commit message in thaikolja/routes. If there's anything else, please let me know.

thaikolja avatar Nov 03 '21 01:11 thaikolja