SimEng icon indicating copy to clipboard operation
SimEng copied to clipboard

Optimise logic in ReorderBuffer::commitMicroOps

Open rahahahat opened this issue 2 years ago • 4 comments

rahahahat avatar Dec 22 '23 08:12 rahahahat

Please add a description, assignee, labels, and ensure the status on the associated github project is correct

FinnWilkinson avatar Dec 22 '23 11:12 FinnWilkinson

Please add a description, assignee, labels, and ensure the status on the associated github project is correct

I've added labels and asignee. I don't think the description is necessary as the title communicates everything that is done. I've just changed one function.

rahahahat avatar Dec 22 '23 16:12 rahahahat

All looks fine, just a few comments made.

Could you add to the description of this PR the performance improvement seen on your local system and on the Mac Studio? (in Release mode). Looking at the Jenkin's performance pipeline results there doesn't seem to be much improvement (with the exception of triad_gcc_a64fx). There are also 2 regressions...

Hmm that seems strange, my access to mac studio is a bit messed up given my laptop broke. Let me see what I can do to address this. It might be compiler dependant though but I will investigate. Thanks.

rahahahat avatar Jan 10 '24 12:01 rahahahat

#rerun tests

jj16791 avatar Jan 30 '24 09:01 jj16791