unstructured icon indicating copy to clipboard operation
unstructured copied to clipboard
verified publisher icon Unstructured-IO

Fix: Add timeout to partition html

Open pratiksinghchauhan opened this issue 2 years ago • 5 comments

This PR adds a timeout parameter to requests in partition_html to stop the code from blocking indefinitely if the URL fails to respond withing the given timeout,

pratiksinghchauhan avatar Jan 17 '24 22:01 pratiksinghchauhan

Hi @pratiksinghchauhan thanks for the contribution. Could you please add a line to CHANGELOG.md under "Fixes" to describe what this change does? And per standard please increase the dev number for the version number?

badGarnet avatar Feb 03 '24 23:02 badGarnet

@badGarnet! I will make the changes and update the PR. Thanks!

pratiksinghchauhan avatar Feb 10 '24 18:02 pratiksinghchauhan

@pratiksinghchauhan - Is this something you'd still like to work on?

MthwRobinson avatar May 15 '24 14:05 MthwRobinson

@MthwRobinson Apologies for the delay! I am still interested in getting this done. I have already completed the feature set just need to get the documentation done. I will get it done this weekend for sure.

pratiksinghchauhan avatar May 15 '24 14:05 pratiksinghchauhan

Sounds good - thanks!

MthwRobinson avatar May 15 '24 15:05 MthwRobinson

@MthwRobinson I have updated the PR. Do let me know.

pratiksinghchauhan avatar May 20 '24 13:05 pratiksinghchauhan