Pulumi.FSharp.Extensions icon indicating copy to clipboard operation
Pulumi.FSharp.Extensions copied to clipboard

Merge fork into main

Open NatElkins opened this issue 1 year ago • 3 comments

This PR is the result of merging master from this repo into main from @cagyirey 's fork.

Most of the changes fall into one of the following categories:

  1. Shifting things around/renaming (that covers most of the deletions of the fsproj files--most were just moved around).
  2. Config/devcontainer/CI things
  3. Formatting changes from fantomas

I thought I would open this PR just to continue the conversation.

@UnoSD , @cagyirey , what do you think?

NatElkins avatar Dec 23 '24 23:12 NatElkins

@NatElkins thanks, @cagyirey has a lot of useful changes.

could anyone split the PR into smaller chunks? as it is, it's not easy to review, merge and test individual changes.

UnoSD avatar Dec 27 '24 06:12 UnoSD

It would be pretty cool if we could merge both efforts since this library is excellent and by adding more contributors the bus factor for it would be a bit higher and the already small pool of F#/Pulumi users would benefit greatly.

purkhusid avatar Jun 13 '25 10:06 purkhusid

It would be pretty cool if we could merge both efforts since this library is excellent and by adding more contributors the bus factor for it would be a bit higher and the already small pool of F#/Pulumi users would benefit greatly.

thank you, @purkhusid

I would love to merge changes, but this PR is massive and, unfortunately, despite being grateful for the contributions, I have very little time to go through all the changes and prioritize the code review. Of course, you're more than welcome to take it and split it in smaller feature chunks and submit the PRs if you can.

UnoSD avatar Jun 13 '25 11:06 UnoSD