github-action-store-variable icon indicating copy to clipboard operation
github-action-store-variable copied to clipboard

Default retention time is being overwritten

Open clamb-respondent opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. Variables stored on friday will expire by monday since the retention period is set to 1. https://github.com/UnlyEd/github-action-store-variable/blob/main/src/manageArtifacts.ts#L49

Describe the solution you'd like If the value was set to 0 then it looks like the default retention setting would be taken.

clamb-respondent avatar Jan 31 '23 18:01 clamb-respondent

Hi, I wasn't aware of that configuration.

I'm not sure what would be the "default" value. See https://github.com/actions/toolkit/blob/c861dd8859fe5294289fcada363ce9bc71e9d260/packages/artifact/src/internal/upload-options.ts#L1

What value would you need for your use case? I believe this could become a new option, with 1 by default, to keep the current behavior by default.

Vadorequest avatar Jan 31 '23 18:01 Vadorequest

Thinking of storing a slack_thread_id so that when a PR is updated the correct slack message is updated too. That said; it's looking like i could just use actions/cache@v3 to store them and pull it from that.

clamb-respondent avatar Jan 31 '23 19:01 clamb-respondent

I wonder if this project is still useful to anyone, I believe the core "setstate" function makes it useless now.

https://github.com/UnlyEd/github-action-store-variable/issues/46

Vadorequest avatar Feb 01 '23 09:02 Vadorequest

Closing as I'm deprecating this project.

Vadorequest avatar Feb 04 '25 10:02 Vadorequest