unleash-client-python icon indicating copy to clipboard operation
unleash-client-python copied to clipboard

Support for Python 3.12

Open josteinl opened this issue 1 year ago • 4 comments

Support for Python 3.12 would be much appreciated.

josteinl avatar Mar 11 '24 14:03 josteinl

We should def. add it to our CI processes but by-in-large our policy is to not use newer language features to ensure compatibility. I think in package metadata only shows lowest version (and honestly needs an update 😢 ).

Is there something in particular that is not working with 3.12?

ivanklee86 avatar Mar 11 '24 15:03 ivanklee86

It seems the mmhash3 package you are using does not support 3.12. At least I had some problems installing it with poetry on windows.

josteinl avatar Mar 11 '24 15:03 josteinl

Just investigating a bit more around the mmhash3 package. It is a fork of the mmh3 package, that already has Python 3.12 support.

So maybe the only thing that needs to be done here is replacing mmhash3 with mmh3.

josteinl avatar Mar 11 '24 16:03 josteinl

@josteinl Oh, thanks for checking that out. We actually originally moved off of that dependency because it didn't support Python 3.11 and wasn't being maintained. I suppose we can just move back to that

sighphyre avatar Mar 13 '24 14:03 sighphyre

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 12 '24 20:04 stale[bot]

@sighphyre Would you accept a PR for this, if still relevant?

josteinl avatar May 07 '24 11:05 josteinl

Whoops, I forgot to make a release with this change. >< I'll publish it now.

ivanklee86 avatar May 07 '24 11:05 ivanklee86