universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

3 manifest attributes no longer shown as metadata attributes

Open nicolasfranck opened this issue 1 year ago • 5 comments

UV version:

 [email protected]

I'm submitting a:

  • [x] bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below

Current behavior: Not sure if this a bug, but in UV4 IIIF v2 attributes attribution, license and logo are added to the moreinfo-right-panel as if they were part of the metadata attribute list.

If you provide a IIIF v3 manifest however, with requiredStatement, rights and provider.0.logo, those attributes are NOT added to the list. Is this old behaviour that is considered deprecated? Where should the license/rights be placed?

Expected behavior:

Steps to reproduce:

  • Use v2 manifest on universalviewer.dev: https://adore.ugent.be/IIIF/manifests/archive.ugent.be:018970A2-B1E8-11DF-A2E0-A70579F64438. The three attributes are added to the right panel
  • Use v3 manifest on universalviewer.dev: https://adore.ugent.be/IIIF/manifests/arxiv. The three attributes are NOT added to the right panel

nicolasfranck avatar Mar 15 '24 13:03 nicolasfranck

@nicolasfranck, I don't know for certain, but it seems more likely this is due to a lack of support for v3 changes than a conscious decision.

Note that the metadata panel is actually a separate component that gets included here; see: https://github.com/IIIF-Commons/iiif-metadata-component -- I suspect that reviewing that code may reveal the cause, and the solution may be a PR over there and an upgrade here.

(But apologies if I'm incorrect -- I unfortunately don't currently have enough free time to look into this myself, but I hope this proves to be a useful pointer in the right direction).

demiankatz avatar Mar 15 '24 14:03 demiankatz

@demiankatz Yes I know about that component ;-). I'll give it a try

Notes:

  • the underlying iiif-metadata-component call helper getMetadata from module manifold: https://github.com/IIIF-Commons/manifold/blob/1373a3343e316096fbb1ae71e2fb2e20de6a994e/src/Helper.ts#L277
  • One can actually add the license to the metadata themselves, or - if there is room - to the requiredStatement, and so get more visibility.

nicolasfranck avatar Mar 15 '24 14:03 nicolasfranck

I've adjusted the relevant components (iiif-metadata-component, manifesto and manifold) in a new fork, and the requiredStatement is now included in the metadata here: https://github.com/jamesmisson/manifold

I'll do the logo and license soon. I'm waiting to hear back from the IIIF devs on how this should be incorporated into the main IIIF Commons — then we can bring it over to UV.

jamesmisson avatar Jun 27 '24 16:06 jamesmisson