universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Dissapearing tree view when collapsing and reopening left-hand panel

Open thattonBL opened this issue 2 years ago • 4 comments

UV version:

 [email protected]

I'm submitting a:

  • [ x] bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below
  • [ ] feature request => please use the user stories repo
  • [ ] support request => Please do not submit support requests here, use stackoverflow

Current behavior:

The tree view that sits within the index tab of the left-hand panel fails to show when the panel is expanded after being collapsed

Expected behavior:

The tree view should re-appear when the left-hand panel is expanded after a collapse

Steps to reproduce:

Using the this manifest as an example: https://api-beta.bl.uk/metadata/iiif/ark:/81055/vdc_100119049146.0x000002/manifest.json In 4.0.18 switch to the index tab then close the left hand panel and then reopen it. The tree view is missing

Related code:

this.extensionHost.subscribe(IIIFEvents.OPEN_LEFT_PANEL, () => {
      if (!this.$element.hasClass("loading")) {
        this.resize();
      }
    });

    this.extensionHost.subscribe(IIIFEvents.OPEN_RIGHT_PANEL, () => {
      if (!this.$element.hasClass("loading")) {
        this.resize();
      }
    });

Other information: The issue is in src\content-handlers\iiif\modules\uv-shared-module\BaseExtension.ts The css class loading is always present

thattonBL avatar Mar 30 '23 14:03 thattonBL

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

LlGC-szw avatar Aug 25 '23 12:08 LlGC-szw

I haven't tried to replicate this but if it's still there I guess it's a bug fix request?

mialondon avatar Sep 12 '23 11:09 mialondon

I've tested the manifest specified above in both UV4 and UV3 in the demo instances on universalviewer.io. I tried this in both Chrome and Firefox on Windows 11 and saw the same results in both environments.

In UV3, the Contents area and the More Information areas are visible, but I can't see the actual audio player or hear the recording. [Link to the demo instance]

In UV4, the Contents area and therefore the hierarchical tree are not visible at all. The audio player loads immediately and the track can be played; the More Information area is present as well and can be opened and closed repeatedly. [Link to the demo instance]

sturkel89 avatar Sep 12 '23 19:09 sturkel89

Thanks, @sturkel89! Is it possible some rules have been changed recently that prevent the left panel from showing when there's only one component to the manifest, even if there's an index that should be displayed? Any ideas why the behavior might have changed between 4.0.18 and now, @edsilv?

demiankatz avatar Sep 12 '23 19:09 demiankatz