Fix textLimit issues in MoreInfo
Text limit was trying to measure the height on elements that weren't rendering in the DOM yet (always 0). A slight pause (100ms) seems to resolve this.
Was built off of #1463 for ease - can likely be cherry-picked. Resolves #1464.
The latest updates on your projects. Learn more about Vercel for Git βοΈ
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| universalviewer | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Jun 26, 2025 3:41pm |
Nice catch, I am good with the code as written and tend to favor Option 1 fix-wise. Only other thing I thought would be worth mentioning is the commit that Demian believes broke this, for historical purposes.
Thanks, @Geoffsc, and full credit to @crhallberg for doing the git bisect work to identify that problem commit. :-)
Thanks @crhallberg , for taking the time to fix the issue, really appreciate it. And of course, thanks to you too, @demiankatz, for spotting the bug in the first place. Nice work, both of you! Seems like Option 1 might be the best way to go, but Iβll leave it to you guys, youβre the experts here. Thanks again!
I have gone through option 1 as recommended by @Geoffsc and @LanieOkorodudu. I am merging this PR now so that #1463 reflects the latest release of iiif-metadata-component. The fix to address #1464 for earlier UV versions can be found in #1471.