universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Evaluate and maintain external repositories

Open LlGC-szw opened this issue 9 months ago • 10 comments

  • [ ] Update additional repos to use main rather than master
  • [x] Raise minimum node version to 20
  • [x] Update tools as per #1400

LlGC-szw avatar May 07 '25 13:05 LlGC-szw

Next Steps

Group A: Components that need discussion that are within UV repo

  • [ ] @universalviewer/aleph - this lives outside of the UV repo in spite of using the UV npm organization; see https://github.com/aleph-viewer/aleph ; it has been superseded by aleph-r3f, so we should investigate the feasibility of replacing it with the maintained version of the dependency.
  • [ ] @universalviewer/uv-ebook-components

Group B: Components that need updates that are outside the UV repo

  • [x] @iiif/manifesto
  • [x] @iiif/manifold
  • [ ] @iiif/presentation-3 - seems maintained beyond UV community; who is responsible?
  • [x] @iiif/vocabulary

Group C: Components with green light to fold back into UV

  • [x] @iiif/iiif-metadata-component - PR ready for review - https://github.com/UniversalViewer/universalviewer/pull/1463
  • [x] @iiif/iiif-tree-component - PR ready for review - https://github.com/UniversalViewer/universalviewer/pull/1481
  • [x] @iiif/iiif-gallery-component - PR ready for review - https://github.com/UniversalViewer/universalviewer/pull/1472

Group D: Possible candidates for folding back, with some complications

  • [ ] @iiif/iiif-av-component - Very large and complex; is folding the best option?
  • [ ] @iiif/base-component - Cannot merge back until iiif-av-component is merged (due to interdependencies).

Group E: Components that need discussion that are in @edsilv's personal repo

  • [x] @edsilv/http-status-codes
  • [x] @edsilv/jquery-plugins
  • [x] @edsilv/key-codes
  • [x] @edsilv/utils

erinburnand avatar Jul 01 '25 15:07 erinburnand

See #1399 for discussion

erinburnand avatar Jul 01 '25 15:07 erinburnand

Just copy the code from the ones on my personal account into the UV repo. I don't use them for anything else.

edsilv avatar Jul 03 '25 15:07 edsilv

I think your best bet is probably to merge iiif-av-component and base-component into the UV. Doesn't really make sense to only have the AV component as separate and means anything else that depends on base-component will be easier to maintain.

edsilv avatar Jul 03 '25 16:07 edsilv

Thanks, @edsilv!

demiankatz avatar Jul 03 '25 16:07 demiankatz

One question that came up, @edsilv: what is the organizational principle behind uv-shared-module? Does everything just go in there, or would something large and complex like av-component justify a separate directory?

demiankatz avatar Jul 03 '25 16:07 demiankatz

I wouldn't put the AV component in there. Shared is just for generic stuff used across other modules

On Thu, 3 Jul 2025, 17:25 Demian Katz, @.***> wrote:

demiankatz left a comment (UniversalViewer/universalviewer#1380) https://github.com/UniversalViewer/universalviewer/issues/1380#issuecomment-3032862072

One question that came up, @edsilv https://github.com/edsilv: what is the organizational principle behind uv-shared-module? Does everything just go in there, or would something large and complex like av-component justify a separate directory?

— Reply to this email directly, view it on GitHub https://github.com/UniversalViewer/universalviewer/issues/1380#issuecomment-3032862072, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFY6MED5NTZPVN3OHQ6OT3GVKN5AVCNFSM6AAAAAB4T6Y6V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZSHA3DEMBXGI . You are receiving this because you were mentioned.Message ID: @.***>

edsilv avatar Jul 04 '25 18:07 edsilv

Hi all, I checked off @edsilv/jquery-plugins because it looks like that already exists in /src/content-handlers/iiif/JQueryPlugins.ts. It looks like all references in code were already updated so I think Ed's repo can likely be archived.

Geoffsc avatar Jul 16 '25 12:07 Geoffsc

Hi all, I checked off @edsilv/jquery-plugins because it looks like that already exists in /src/content-handlers/iiif/JQueryPlugins.ts. It looks like all references in code were already updated so I think Ed's repo can likely be archived.

Thanks for the detective work, @Geoffsc. If that's the case, it should be possible to open a PR that just commits the results of npm uninstall @edsilv/jquery-plugins since apparently the package is redundant anyway. If everything still works after doing that, I think we're all set!

demiankatz avatar Jul 16 '25 12:07 demiankatz

I also took a moment to diff the @edsilv/jquery-plugins version of the code vs. the version included in UV, and they seem pretty similar, with the main differences being accessibility improvements in the UV version. In other words, I don't think there's anything from the external repo that needs to be pulled in here. The only thing I saw in the external version that seemed absent from the UV version was code to trigger the onPressed callback in response to touchstart events... but I suspect that may have been intentionally removed from the UV version due to unwanted side effects.

demiankatz avatar Jul 16 '25 12:07 demiankatz