universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Changes attribution close button label. Fixes #1075

Open LlGC-mag opened this issue 1 year ago • 2 comments

Fixes #1075

Supersedes #1160

Applies option 1 from https://github.com/UniversalViewer/universalviewer/pull/1160#pullrequestreview-2388177647

@demiankatz I think this is what you described in option 1 but this is my first typescript project so please excuse any misunderstandings!

LlGC-mag avatar Oct 23 '24 12:10 LlGC-mag

The latest updates on your projects. Learn more about Vercel for Git ā†—ļøŽ

Name Status Preview Comments Updated (UTC)
universalviewer āœ… Ready (Inspect) Visit Preview šŸ’¬ Add feedback Oct 23, 2024 0:21am

vercel[bot] avatar Oct 23 '24 12:10 vercel[bot]

(I'll wait for one more tester to confirm before hitting merge, just to be on the safe side).

demiankatz avatar Oct 23 '24 12:10 demiankatz

@demiankatz. I've reviewed this and can confirm the fix when comparing it with the dev branch. The only remaining step is to verify it using a screen reader. I’m currently awaiting approval from our service desk to download the NVDA screen reader so I can complete this testing.

LanieOkorodudu avatar Oct 29 '24 16:10 LanieOkorodudu