universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Update $next and $previous strings (fixes #1087)

Open LlGC-mag opened this issue 1 year ago • 1 comments

Fixes https://github.com/UniversalViewer/universalviewer/issues/1087

Updated $next and $previous strings for en-GB, cy-GB, sv-SE, fr-FR, pl-PL

Tested using VoiceOver on MacOS

LlGC-mag avatar Oct 23 '24 10:10 LlGC-mag

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 4:31pm

vercel[bot] avatar Oct 23 '24 10:10 vercel[bot]

@scoutb-cogapp, any thoughts on this one? I understand your original request in principle, but I wonder if the approach here needs a little adjustment in practice. Your input would be valuable!

demiankatz avatar Oct 29 '24 16:10 demiankatz

I agree @demiankatz

'Next button' describes what it is, not what it does, and from what little I've learned in the last couple of weeks using NVDA, a screen reader will first tell the user that it's a button, and then what the label says.

So my vote is for 'Next image' and 'Previous image' on any button that performs those functions.

LlGC-jop avatar Nov 08 '24 09:11 LlGC-jop

Thanks, @LlGC-jop. So I think we should revert the changes made here and instead find where the strings are set for those buttons and adjust them to use the existing $nextImage / $previousImage translations instead of plain $next / $previous. Would you or @LlGC-mag be interested in adjusting this existing PR, or should we close it and start a new one?

demiankatz avatar Nov 09 '24 12:11 demiankatz

I'm going to close this PR and create a new one as the resulting merge is a bit messy

LlGC-mag avatar Nov 18 '24 16:11 LlGC-mag

Thanks, @LlGC-mag, that makes sense to me!

demiankatz avatar Nov 18 '24 16:11 demiankatz