UniversalViewer
Makes disable animations work across all extensions' expand panels and makes it a global config
Fixes #756
Reduced animations should now be available as a global config setting on the in-use extension so if any other modules have animations in future they can refer to it.
Also fixes the problem where the config didn't persist between refreshes.
Tested locally on OSD, PDF, Video, Audio, & 3D
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| universalviewer | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 22, 2024 0:51am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
In happier news, you can add "default extension" and "eBook extension" to the list of tested extensions where the setting does work as expected. :-)
Thanks @demiankatz, not sure how I missed that. The code's right below the stuff I changed!
Should be ok now.
There is one more I've found, the way the controls in OSD fade in/out, however I think that's a new issue as it's probably a setting in OSD (or needs one adding).
Good point, @LlGC-jop! Do you want to open a new issue to track that one, and then once this is tested, we can merge it as incremental progress?
@demiankatz @LlGC-jop Hi Jonathan and Demian - I tested the fix here and I can see a difference when the checkbox is ticked for change in motion for both OSD & PDF, however, I am less certain about the other item types - i.e. Video, Audio, & 3D as I struggle to see any difference in motion when opening and closing the side panels.
@damodeburca, I just re-checked this video example. If the "reduce motion" box is checked in settings, the "more info" panel on the right snaps open and closed instantly. If the box is unchecked, you can see it sliding back and forth. Are you seeing different behavior? Is there a different manifest you are testing with that behaves differently?
@demiankatz @LlGC-jop - Hi guys, I retested the 'reduce animation' check box with audio and 3D again and I am happy that this fix is working