ml-agents icon indicating copy to clipboard operation
ml-agents copied to clipboard

add an option to change timeout before unity responds

Open dmitryponv opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe.

mlagents-learn times out when Unity play is not pressed. Sometimes unity play takes 30 seconds to start, and MLAgents-learn times out by then

Describe the solution you'd like Please add a --timeout or some similar option when starting mlagents-learn

dmitryponv avatar Jan 28 '22 22:01 dmitryponv

Great suggestion. This is also useful as while debugging in Unity editor, the trainer might disconnect on pause

CubeMD avatar Jan 30 '22 22:01 CubeMD

Thanks for reaching out! We've logged this request internally as MLA-2401.

miguelalonsojr avatar Feb 09 '22 02:02 miguelalonsojr

please also support turning the timeout off :)

AVOlight avatar Mar 28 '22 22:03 AVOlight

I guess there's still no update on this, right? Such a simple feature would be extremely useful, especially when starting a large batch of standalone builds

danielebanovaz avatar Jul 27 '23 14:07 danielebanovaz

I see it has been now "closed as complete". Does it mean that request MLA-2401 has been fully implemented and it's available in the upcoming release of ML-Agents?

danielebanovaz avatar Oct 09 '23 06:10 danielebanovaz

No. Thanks for reaching out. This was closed en masse to clean up old issues and requests. Re-opening as this should be an easy addition. No ETA on implementation though. But will keep open.

miguelalonsojr avatar Oct 09 '23 11:10 miguelalonsojr

Thank you very much for clarifying!

danielebanovaz avatar Oct 09 '23 11:10 danielebanovaz

The update was easy enough. Here's the PR: https://github.com/Unity-Technologies/ml-agents/pull/5991

miguelalonsojr avatar Oct 09 '23 14:10 miguelalonsojr

This feature has been implemented.

miguelalonsojr avatar Oct 10 '23 13:10 miguelalonsojr