ml-agents icon indicating copy to clipboard operation
ml-agents copied to clipboard

[bug-fix] Fix sequence length buffer truncate

Open ervteng opened this issue 4 years ago • 1 comments

Proposed change(s)

Fixed an issue where if 80% of the buffer isn't a multiple of sequence length, we'll get weird sequences in the buffer. Only affects SAC with LSTM.

Types of change(s)

  • [x] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ ] Breaking change
  • [ ] Documentation update
  • [ ] Other (please describe)

Checklist

  • [x] Added tests that prove my fix is effective or that my feature works
  • [x] Updated the changelog (if applicable)
  • [ ] Updated the documentation (if applicable)
  • [ ] Updated the migration guide (if applicable)

Other comments

ervteng avatar Jul 15 '21 00:07 ervteng

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ervin Teng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 01 '24 01:04 CLAassistant