ml-agents icon indicating copy to clipboard operation
ml-agents copied to clipboard

Hot Load and Chunked Save of Demo Files

Open ervteng opened this issue 4 years ago • 1 comments

Proposed change(s)

Adds two new IL improvements: allow for adding additional .demo files during a training run, and saves new demos from the DemonstrationWriter in chunks of Num Steps to Record size.

You can combine these two features to do online IL by pointing the writer and the GAIL/BC YAML to the same folder, but no explicit way of doing online has been added.

Also fixed a longstanding bug that if multiple demo files are in a folder, they are all treated as one long appended file, which is not correct as the final obs/action pair will be joined with the first one from the next file.

Types of change(s)

  • [ ] Bug fix
  • [x] New feature
  • [ ] Code refactor
  • [ ] Breaking change
  • [ ] Documentation update
  • [ ] Other (please describe)

Checklist

  • [x] Added tests that prove my fix is effective or that my feature works
  • [ ] Updated the changelog (if applicable)
  • [ ] Updated the documentation (if applicable)
  • [ ] Updated the migration guide (if applicable)

Other comments

ervteng avatar Jul 14 '21 23:07 ervteng

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ervin Teng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 01 '24 01:04 CLAassistant