feat: actions and actionsfx merge MTT-4244 MTT-4344

Open pdeschain opened this issue 3 years ago • 0 comments

This PR introduces changes to our action system:

I've merged Action and ActionFX into a new Action class - both server and client logic now runs in the same class
I've taken my chance to rename Server and Client action players accordingly, from their prior quite arbitrary names.
all Action types are now scriptable objects
ActionType is removed, ActionLogic stays
Instead of relying on a ActionType enum we now can figure out what an action is by using an ActionID - a runtime ID that's generated by all peers from the GameDataSource information

Things to consider:

We still heavily rely on a rather pervasive singleton - GameDataSource , but it's better to take it's refactoring as a separate PR.
I'm thinking that we probably should pool instances of actions instead of Instantiating them all the time

MTT-4244 MTT-4344

[ ] Tests have been added for boss room and/or utilities pack
[ ] Release notes have been added to the project changelog file and/or package changelog file
[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] JIRA ticket ID is in the PR title or at least one commit message
[x] Include the ticket ID number within the body message of the PR to create a hyperlink

Aug 03 '22 17:08 pdeschain