com.unity.multiplayer.samples.coop icon indicating copy to clipboard operation
com.unity.multiplayer.samples.coop copied to clipboard
verified publisher icon Unity-Technologies

feat: PubSub improvement: ISubscriber unsub [MTT-2765]

Open pdeschain opened this issue 3 years ago • 3 comments

Description

Turned out to be a one-liner change that would allow us to also Usubscribe from ISubscribers.

Issue Number(s)

MTT-2765

Contribution checklist

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] JIRA ticket ID is in the PR title or at least one commit message
  • [x] Include the ticket ID number within the body message of the PR to create a hyperlink
  • [x] Added to changelog

pdeschain avatar Apr 13 '22 17:04 pdeschain

With this, I would have expected to see changes in callsites of ISubscriber no? What kinds of improvements can we do with this?

SamuelBellomo avatar Apr 13 '22 17:04 SamuelBellomo

Keep Dispose for bundled dispose, for single dispose, can use symmetrical unsubscribe.

SamuelBellomo avatar Apr 26 '22 18:04 SamuelBellomo

Adding this for all PRs that have been opened since this new flow has been added. Please add your changelog here project changelog file and/or package changelog file

SamuelBellomo avatar May 12 '22 19:05 SamuelBellomo