Unity-Technologies
Adds safety checks for bad animation data
Some optimized GLB files can contain animation data that causes a null reference exception here. This PR adds a safety check for that that causing issues.
@timokorkalainen Thanks for the contribution.
Could you provide examples/glTFs that trigger the error?
While defensive coding (with check like yours) is good in general, I want to make sure we're not hiding potential problems and make them hard to find. If there's a problem with our code, we should fix it. If there's a problem with the input/glTF, we should report/log it.
I've done my own attempt of achieving more resilience in this particular part of the code base, therefore closing this pull request.
The upside is that now there's either a proper error message/log when the glTF is invalid or a runtime error (assertion) when there are internal inconsistencies.
Again, thanks for the work!
@timokorkalainen Thanks for sending me a test file on another channel.
TIL that if an accessor's bufferView is not set, it is still valid and its values should get initialized with zeroes.
Therefor the initial PR would indeed have masked the actual problem, which is now tracked in #24.