Unity-Robotics-Hub icon indicating copy to clipboard operation
Unity-Robotics-Hub copied to clipboard

Update 0_ros_setup.md

Open Spice-Weasel opened this issue 2 years ago • 1 comments

Proposed change(s)

docker build and docker run require root privileges - I have added the sudo command to these in order to be consistent with the rest of the setup instructions.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ x] Documentation update
  • [ ] Other (please describe)

Testing and Verification

Ran commands as normal user without privileges, they fail with permission denied. They need to be added to the docker commands.

Test Configuration:

  • Unity Version: [e.g. Unity 2020.2.0f1]
  • Unity machine OS + version: [Ubuntu 22.04]
  • ROS machine OS + version: [e.g. Ubuntu 18.04, ROS Noetic]
  • ROS–Unity communication: [e.g. Docker]

Checklist

  • [ ] Ensured this PR is up-to-date with the dev branch
  • [ ] Created this PR to target the dev branch
  • [ ] Followed the style guidelines as described in the Contribution Guidelines
  • [ ] Added tests that prove my fix is effective or that my feature works
  • [ ] Updated the Changelog and described changes in the Unreleased section
  • [x ] Updated the documentation as appropriate

Other comments

Spice-Weasel avatar Oct 02 '23 11:10 Spice-Weasel

CLA assistant check
All committers have signed the CLA.

unity-cla-assistant avatar Oct 02 '23 11:10 unity-cla-assistant