URDF-Importer icon indicating copy to clipboard operation
URDF-Importer copied to clipboard

AIRO-1796 Change API used to set and query maximum, velocity of a joint.

Open vidurvij-Unity opened this issue 3 years ago • 2 comments

Proposed change(s)

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

https://github.com/Unity-Technologies/URDF-Importer/issues/189

Types of change(s)

  • [x] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ ] Documentation update
  • [ ] Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

  • Unity Version: [e.g. Unity 2020.2.0f1]
  • Unity machine OS + version: [e.g. Windows 10]
  • ROS machine OS + version: [e.g. Ubuntu 18.04, ROS Noetic]
  • ROS–Unity communication: [e.g. Docker]

Checklist

  • [x] Ensured this PR is up-to-date with the dev branch
  • [x] Created this PR to target the dev branch
  • [x] Followed the style guidelines as described in the Contribution Guidelines
  • [x] Added tests that prove my fix is effective or that my feature works
  • [ ] Increased the test coverage criteria by 3%
  • [ ] Updated the Changelog and described changes in the Unreleased section
  • [ ] Updated the documentation as appropriate

Other comments

vidurvij-Unity avatar Mar 03 '22 09:03 vidurvij-Unity

@K-Tone One of the test is failing. It is down to the fact that I am not able to set this during editorMode. Is this intended or a bug ?

vidurvij-Unity avatar Mar 03 '22 20:03 vidurvij-Unity

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

unity-cla-assistant avatar May 21 '23 21:05 unity-cla-assistant