ROS-TCP-Connector icon indicating copy to clipboard operation
ROS-TCP-Connector copied to clipboard

P3te/ros2 nsecs fix

Open P3TE opened this issue 2 years ago • 0 comments

Proposed change(s)

Fixing infinite recursion causing a StackOverlowException.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

https://github.com/Unity-Technologies/ROS-TCP-Connector/issues/307

Types of change(s)

  • [X] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ ] Documentation update
  • [ ] Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Checklist

  • [X] Ensured this PR is up-to-date with the dev branch
  • [X] Created this PR to target the dev branch
  • [X] Followed the style guidelines as described in the Contribution Guidelines
  • [ ] Added tests that prove my fix is effective or that my feature works
  • [X] Updated the Changelog and described changes in the Unreleased section
  • [X] Updated the documentation as appropriate

Other comments

P3TE avatar Jun 07 '23 02:06 P3TE