NativeVersionControlPlugins icon indicating copy to clipboard operation
NativeVersionControlPlugins copied to clipboard

Fix all warnings in a Windows build.

Open kmackeyp4 opened this issue 4 years ago • 1 comments

A few code changes fixed warnings, removed debug info for release builds, and added condition for copying .pbd which is not present in a release build.

Purpose of this PR

Hundreds of warnings were generated during a build. Some required code changes.


Testing status

Couldn't get tests to work. Installed Perforce server, but tests couldn't locate server files. Couldn't find test documentation.


Comments to reviewers

@ignas2 Can you review this, and/or let me know how to run the tests?

11/02 8:30 AM PT Still waiting to hear from Fernando, who you referred me to, and who was emailed on 10/28. 11/03 4:12 AM PT Email from Fernando that it will be reviewed as soon as possible.

kmackeyp4 avatar Oct 22 '21 16:10 kmackeyp4

Please check your email. I've replied to the message from you and Steen.

ignas2 avatar Oct 28 '21 06:10 ignas2