InputSystem icon indicating copy to clipboard operation
InputSystem copied to clipboard

Added to generated C# wrapper action maps support for subscribing mul…

Open Ramobo opened this issue 6 years ago • 3 comments

…tiple interfaces and a ClearCallbacks method

Closes #823.

Ramobo avatar Sep 30 '19 21:09 Ramobo

Is there something wrong here? An issue that needs my attention? It's been 12 days and nothing.

Ramobo avatar Oct 12 '19 21:10 Ramobo

Sorry to leave you hanging.

ATM we're not merging feature PRs in order to not rock the boat for 1.0. Once 1.0 out for good (shouldn't be too long), we'll open the develop branch back up for feature work.

As far as the changes here go, I think it makes sense to extend the generated code to allow multiple receivers. Not exactly this way but something along the lines. Something to look at I don't think this is quite the right change. At least not at this point, after 1.0 is out, I think it makes sense to consider a change to the code generator.

Rene-Damm avatar Oct 14 '19 10:10 Rene-Damm

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

unity-cla-assistant avatar Jun 03 '21 08:06 unity-cla-assistant

Closing this PR since a similar change have been routed via https://github.com/Unity-Technologies/InputSystem/pull/1593. It was slightly modified to not break backwards compability. Thanks for your contribution and it has been mentioned in the CHANGELOG.md.

ekcoh avatar Oct 11 '22 07:10 ekcoh