v3-periphery icon indicating copy to clipboard operation
v3-periphery copied to clipboard

PoolAddress lib returns wrong addresses in version 0.8

Open larryob opened this issue 3 years ago • 3 comments

This commit seems to be the cause. You can find an example of this error here.

larryob avatar Oct 11 '22 05:10 larryob

@larryob is right. I have same problem because in both versions POOL_INIT_CODE_HASH are hardcoded and in 0.8 version we also need POOL_INIT_CODE_HASH == 0xe34f199b19b2b4f47f68442619d555527d244f78a3297ea89325f843f87b8b54 for correct address computation. Can you please unhardcode it or downgrade? @NoahZinsmeister @ewilz @moodysalem

drLis avatar Nov 30 '22 03:11 drLis

Possible it will be more corrent make POOL_INIT_CODE_HASH argument of function for that library?

drLis avatar Nov 30 '22 03:11 drLis

There is a possible ambiguous truncation there, that's why it fails on up to date version of the compiler.

andreujuanc avatar Dec 04 '22 14:12 andreujuanc