routing-api icon indicating copy to clipboard operation
routing-api copied to clipboard

chore: bump sor to 4.0.0 - feat(breaking): top-level alpha router native currencyIn, currencyIn, quoteCurrency support

Open jsy1218 opened this issue 1 year ago • 2 comments

Release https://github.com/Uniswap/smart-order-router/pull/721.

I ran all the e2e tests against local routing-api instance, and saw that the cached routes hit rate is still significantly higher than miss rate, which gives me the confidence the change is working as expected:

Screenshot 2024-09-24 at 11.40.35 AM.png

jsy1218 avatar Sep 24 '24 18:09 jsy1218

  • #844 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

jsy1218 avatar Sep 24 '24 18:09 jsy1218

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/[email protected] Transitive: environment, eval, filesystem, network, shell +109 119 MB

🚮 Removed packages: npm/@uniswap/[email protected]

View full report↗︎

socket-security[bot] avatar Sep 24 '24 18:09 socket-security[bot]

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (09/24/24)

4 reviewers were added and 1 assignee was added to this PR based on 's automation.

graphite-app[bot] avatar Sep 24 '24 21:09 graphite-app[bot]

Shall we add some tests for the v4 case?

potentially unit test. We aren't able to add native currency routing e2e test, because we don't have a native currency pool in sepolia pool manager.

Update - just added native currency routing cached routes unit test @cgkol

jsy1218 avatar Sep 24 '24 21:09 jsy1218

Merge activity

  • Sep 24, 6:15 PM EDT: @jsy1218 started a stack merge that includes this pull request via Graphite.
  • Sep 24, 6:15 PM EDT: @jsy1218 merged this pull request with Graphite.

jsy1218 avatar Sep 24 '24 22:09 jsy1218