routing-api icon indicating copy to clipboard operation
routing-api copied to clipboard

Change naming of JSON_RPC_PROVIDER urls to use the Chain Name instead of ChainId

Open zhongeric opened this issue 3 years ago • 1 comments

If the idea is to keep routing-api inline with SOR usage, the .env variables should be:

   JSON_RPC_PROVIDER_{CHAIN NAME} = { RPC Provider}
   # Ex: JSON_RPC_PROVIDER_MAINNET
   ...

It's also a lot easier to read

Also update README to remove // in example CURL req curl --request GET '<INSERT_YOUR_URL_HERE>/quote?tokenInAddress=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2&tokenInChainId=1&tokenOutAddress=0x1f9840a85d5af5bf1d1762f925bdaddc4201f984&tokenOutChainId=1&amount=100&type=exactIn' to curl --request GET '<INSERT_YOUR_URL_HERE>quote?tokenInAddress=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2&tokenInChainId=1&tokenOutAddress=0x1f9840a85d5af5bf1d1762f925bdaddc4201f984&tokenOutChainId=1&amount=100&type=exactIn'

zhongeric avatar Jul 13 '22 15:07 zhongeric

Hi, There is a problem that I am trying to figure out since 1 day, the APIs are successfully deployed on AWS. But during API calls It returns an internal server error in response. I followed the steps in the documentation which is connected to an AWS account and it deployed successfully. If i change the JSON_RPC_PROVIDER_{CHAIN ID} = { RPC Provider} with JSON_RPC_PROVIDER_{CHAIN NAME} = { RPC Provider} so it does not effect on the code. Can you help me to understand the AWS arn to how to add key value credential in secret manager arn and also how to rpc add in env.

ProtonAnwar avatar Feb 19 '24 13:02 ProtonAnwar