MetPy icon indicating copy to clipboard operation
MetPy copied to clipboard

add declarative skewt plotting

Open kgoebber opened this issue 3 years ago • 5 comments

Description Of Changes

This PR add the ability to create a SkewT plot through the declarative syntax. In addition to that, I have implemented a function for plotting skewT special lines with labels (based off of code from @DrKimWood, thanks!). There is some slight reorganization of declarative to anticipate some repeated code - we'll see what the checkers say to potentially do more of that.

This is initially a draft PR to allow for comments and evolution on naming and other things within the code.

A few tests have been added, but there could likely be more.

If anyone would like to take this draft forward, please feel free!

Checklist

  • [ ] Closes #xxxx
  • [x] Tests added
  • [x] Fully documented

kgoebber avatar May 19 '22 23:05 kgoebber

Not sure why exactly this is failing with our minimum versions. Also, this is now conflicting with declarative.py.

dopplershift avatar Sep 16 '22 21:09 dopplershift

Yeah, I don't know why its conflicting with minimum, other than there was some difference with Matplotlib 3.3.0 compared to current versions?

kgoebber avatar Sep 17 '22 00:09 kgoebber

Yes, I had conflicts with the latest rebase due to pulling out some elements to a PanelTraits class since this PR introduces a new Panel type (SkewPanel along with our long standing MapPanel). There were also some other conflicts with the addition of ArrowPlot. Now that the additional titles are merged, I'll rebase on the current main and see if we can get a cleaner merge.

kgoebber avatar Sep 17 '22 00:09 kgoebber

I've come across a small package called matplotlib-label-lines that might be a better solution than what is implemented in the PR. Thoughts on using this or adopting some of their code?

kgoebber avatar Aug 23 '23 15:08 kgoebber