OctoDash icon indicating copy to clipboard operation
OctoDash copied to clipboard

Install to `.zshrc` instead of `.bashrc`

Open yidingzh opened this issue 3 years ago • 2 comments

https://github.com/UnchartedBull/OctoDash/blob/67982db0340f7ea27c348b5a6dbabb2335ba0c92/scripts/install.sh#L801

Actually scratching my head an hour on why it's not working. Finally figured out it's hard coded as bashrc here.

Can you include something like the following?

if [[ -f ~/.zshrc ]]; then
  rcfile = '~/.zshrc'
fi

yidingzh avatar Jul 07 '22 01:07 yidingzh

As a workaround, like many install scripts, the readme could include a /bin/bash call to the downloaded script to ensure the script is run by bash.

cryptoAlgorithm avatar Jul 08 '22 11:07 cryptoAlgorithm

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 08 '23 04:01 stale[bot]