PiCANet-Implementation icon indicating copy to clipboard operation
PiCANet-Implementation copied to clipboard

incorrect lr adjust

Open Zyun-Y opened this issue 5 years ago • 1 comments

hi,

I found an error in your code.

in the training part, you wrote 'if i + epo * len(dataloader) % decay_step == 0 and i != 0:' by doing this, the learning rate never update.

the correct version I think should be 'if (i + epo * len(dataloader)) % decay_step == 0 and i != 0':

Zyun-Y avatar Oct 20 '20 17:10 Zyun-Y

I think you are right. I updated train.py. My code has a lot of out-dated coding style, and I recommend you use pytorch's lr-scheduler. I have a plan to update this repository with torch >= 1.4.0, but it would take some time. Thank you for making a comment.

Ugness avatar Oct 22 '20 07:10 Ugness