STIR icon indicating copy to clipboard operation
STIR copied to clipboard

Scatter Estimation / Sinogram interpolation in 3D

Open NikEfth opened this issue 3 years ago • 6 comments

This is in good shape. I have tested with data from various scanners. But more testing is needed and updates in the documentation and such.

@KrisThielemans I am not sure if you would like to change the recon_tests to test this in addition to the existing one.

NikEfth avatar Feb 08 '23 18:02 NikEfth

Sadly, there's white-space changes here, which seems a bit arbitrary. I'd prefer to revert these. If there are any, they should be compatible with our clang-format.

Where is the .clang-format file?

NikEfth avatar Feb 17 '23 19:02 NikEfth

Where is the .clang-format file?

in the STIR root 😄

KrisThielemans avatar Mar 16 '23 08:03 KrisThielemans

Sadly, #1172 will generate a lot of conflicts with this PR., and I need to merge that first (it fixes a bug). However, as #1172 simplifies the logic of the scatter umsampling, hopefully it isn't too hard to take it into account here.

Sorry, a case of development in the same place at the same time.

KrisThielemans avatar Mar 16 '23 08:03 KrisThielemans

Ok, no worries. Let me know when to pull it or should I wait for the master?

NikEfth avatar Mar 16 '23 13:03 NikEfth

better to wait till it's on master I think. @markus-jehl is going to finish this soon.

KrisThielemans avatar Mar 16 '23 13:03 KrisThielemans

Also, let me know if you have questions about the changes I made, @NikEfth.

markus-jehl avatar Mar 16 '23 14:03 markus-jehl