Aegisub icon indicating copy to clipboard operation
Aegisub copied to clipboard

Script Resolution Mismatch dialogue box not working as intended

Open OrangeChannel opened this issue 6 years ago • 0 comments

https://github.com/TypesettingTools/Aegisub/blob/26ccf0b8e5374973b3a5edfe2bd958a1a2040da1/src/dialog_video_properties.cpp#L128-L131

image As @Myaamori pointed out, the above dialogue box has the same behavior for both options. It will rescale all override tags to the video resolution for either option, even though the Set to video resolution option should only be editing the script properties (like in the window below) according to src/dialog_video_properties.ccp.

image

The only way to set to video resolution correctly as of now, is hitting Cancel on the mismatch dialogue, and then hitting From video in the Script Properties window.


Steps to reproduce:

  • (Assuming the user has Match video resolution on open set to Ask under Preferences > General > Video)
  1. Create a script at 1280x720 using at least one non-interger override tag (\pos for example)
  2. Open a video at a different resolution
  3. Test Set to video resolution
  4. Repeat steps 1-2 for Resample script
  5. Repeat steps 1-2 and click Cancel
  6. Now, go to File > Properties... and set script resolution from video, and observe that no tags are scaled

OrangeChannel avatar Mar 12 '19 21:03 OrangeChannel