ts-node icon indicating copy to clipboard operation
ts-node copied to clipboard

Investigate `lineOffset` argument to `compile`; figure out if it is implemented correctly

Open cspotcode opened this issue 5 years ago • 1 comments

Our compile function accepts a third argument, lineOffset

The REPL passes a value, but the implementation ignores that argument.

Should we be using it for something? Is it meant to modify error line numbers so that REPL errors are always starting at line 1?

I suspect this may be something that I broke, erroneously assuming that it was not important.

@blakeembrey do you remember?

cspotcode avatar Oct 31 '20 23:10 cspotcode

You're correct for the intended usage, though I don't think you broke it. I feel like I broke it when trying to refactor for TypeScript incremental compilation or something. Not sure how easy it is to add back everywhere.

blakeembrey avatar Nov 01 '20 23:11 blakeembrey