`ignore` option docs unclear; should point out they're regexps

Open cspotcode opened this issue 5 years ago • 2 comments

It's not clear that the ignore option is an array of regexps which are passed to new RegExp. I think we can be clearer about this.

Whatever docs update we make for this will also address #1063

EDIT: also the schema default value is wrong. Default is a string but should be an array.

Jul 29 '20 05:07 cspotcode

Is this issue still open? Is it referring to this documentation here: https://github.com/TypeStrong/ts-node/blob/main/README.md#ignore-by-regexp?

Oct 13 '22 17:10 panchoroo

@cspotcode Based on these comments, it would appear that the appropriate documentation has been completed by you in this PR: https://github.com/TypeStrong/ts-node/pull/1155/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80. If there are no additional changes needed to the documentation, it would appear that this issue is safe to close.

Oct 15 '23 18:10 andrewmedhurst