BlockNote icon indicating copy to clipboard operation
BlockNote copied to clipboard

fix: update CreateLinkButton to be able to toggle popover visibility

Open jbpenrath opened this issue 1 month ago • 3 comments

Summary

Fix an issue with the CreateLinkButton component which cannot be closed. This problem was hidden with non static formatting toolbar as the component was unmount with the toolbar. But with static toolbar, once the link popover was opened, it was not possible to close it.

#2313

Rationale

Fix a bug that cause lot of feedbacks/support in the application I'm developing.

Changes

Make the CreateLinkButton Popover fully controlled.

Impact

Testing

Tested during development through the static formatting toolbar example.

Screenshots/Video

https://github.com/user-attachments/assets/9234d8e5-9ed2-4868-bdce-bdd184105611

Checklist

  • [x] Code follows the project's coding standards.
  • [ ] Unit tests covering the new feature have been added. (I don't see any test suite for the react package)
  • [x] All existing tests pass.
  • [N/A] The documentation has been updated to reflect the new feature

Additional Notes

jbpenrath avatar Dec 23 '25 17:12 jbpenrath