TypeCellOS
Large ydoc using yprovider causing the blocknote to crash
Describe the bug
hook.js:608 Caught error while handling a Yjs update Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
at throwIfInfiniteUpdateLoopDetected (react-dom.development.js:26793:11)
at getRootForUpdatedFiber (react-dom.development.js:7627:3)
at enqueueConcurrentRenderForLane (react-dom.development.js:7549:10)
at forceStoreRerender (react-dom.development.js:12049:14)
at handleStoreChange (react-dom.development.js:12028:7)
at eval (blocknote-react.js:2687:27)
at Set.forEach (
To Reproduce use the similar code in ypartykit
async onConnect(connection: Party.Connection) {
return onConnect(connection, this.room, {
load: async () => {
// This is called once per "room" when the first user connects
const doc = new Y.Doc();
const response = await fetch(
url,
{
method: 'GET',
headers: {
'Accept': 'application/json',
},
},
);
if (!response.ok) {
const errorDetails = await response.text();
console.error(
`Failed to load ydoc from persistent database: ${response.status}: ${response.statusText}\nDetails: ${errorDetails}`,
);
return doc;
}
const data = await response.json();
if (data.document) {
Y.applyUpdate(doc, Buffer.from(data.document, 'base64'));
}
return doc;
},
callback: {
handler: async (yDoc) => {
...
},
});
}
and nextjs code:
const editor = useCreateBlockNote(
{
collaboration: {
provider,
fragment: doc.getXmlFragment('document-store'),
user: {
name: mobxstore.user.userInfo.username,
color: userColor,
},
},
schema: customSchema,
_tiptapOptions: {
extensions: [
Extension.create({
name: 'customKeyEvents',
priority: 1000,
addProseMirrorPlugins() {
return [
new Plugin({
key: new PluginKey('customKeyEvents'),
props: {
handleKeyDown: (view, event) =>
handleKeyDown(event),
},
}),
];
},
}),
],
},
},
[doc, provider],
);
Misc
- Node version: v20.9.0
- Package manager: either of blocknote version tried are 0.24.2 and v.0.15.3
- Browser: Arc ir Chrome
- [ ] I'm a sponsor and would appreciate if you could look into this sooner than later 💖
Thanks for reporting. Would it be possible to create a fully reproducible example of this? ( Best is to provide an online sandbox, click to create one )
quite hard to share a fully useable sandbox because my codebase is too large now. But what I realize is that I created a custom codeblock schema to use in blocknote with yjs. And in one page at once there can be tens of codeblocks showing at the same time. My suspicion is that they are all binded to the yjs update each, causing the react stack to be unable to handle so many of them all at once. Could this be possible?
I'm going to close this as we need a reproducible example to diagnose further